From 47846e264171bbe4b8dc2e9607e149a105b49142 Mon Sep 17 00:00:00 2001 From: Shekar Siri Date: Sun, 27 Feb 2022 17:17:05 +0100 Subject: [PATCH 1/3] fix(ui) - metadata in offline session --- .../Session_/EventsBlock/Metadata/Metadata.js | 16 +++++++++------- .../EventsBlock/Metadata/MetadataItem.js | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/app/components/Session_/EventsBlock/Metadata/Metadata.js b/frontend/app/components/Session_/EventsBlock/Metadata/Metadata.js index b0dca0956..0992c0f88 100644 --- a/frontend/app/components/Session_/EventsBlock/Metadata/Metadata.js +++ b/frontend/app/components/Session_/EventsBlock/Metadata/Metadata.js @@ -10,13 +10,15 @@ export default connect(state => ({ metadata: state.getIn([ 'sessions', 'current', 'metadata' ]), }))(function Metadata ({ metadata }) { const [ visible, setVisible ] = useState(false); - const toggle = useCallback(() => metadata.length > 0 && setVisible(v => !v), []); + const metaLenth = Object.keys(metadata).length; + const toggle = useCallback(() => metaLenth > 0 && setVisible(v => !v), []); + return ( <> ({ } on="click" - disabled={metadata.length > 0} + disabled={metaLenth > 0} size="tiny" inverted position="top center" /> { visible &&
- - { metadata.map((i) => { - const key = Object.keys(i)[0] - const value = i[key] + + { Object.keys(metadata).map((key) => { + // const key = Object.keys(i)[0] + const value = metadata[key] return }) } diff --git a/frontend/app/components/Session_/EventsBlock/Metadata/MetadataItem.js b/frontend/app/components/Session_/EventsBlock/Metadata/MetadataItem.js index 8abd1913c..76cf459b0 100644 --- a/frontend/app/components/Session_/EventsBlock/Metadata/MetadataItem.js +++ b/frontend/app/components/Session_/EventsBlock/Metadata/MetadataItem.js @@ -49,7 +49,7 @@ export default class extends React.PureComponent { content={ open && } onClose={ open ? this.switchOpen : () => null } /> -
+
{ item.key }
Date: Sun, 27 Feb 2022 18:03:03 +0100 Subject: [PATCH 2/3] fix(ui) - performance var check --- frontend/app/components/Session_/Performance/Performance.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/app/components/Session_/Performance/Performance.js b/frontend/app/components/Session_/Performance/Performance.js index b31d1ed85..78aea13ce 100644 --- a/frontend/app/components/Session_/Performance/Performance.js +++ b/frontend/app/components/Session_/Performance/Performance.js @@ -115,7 +115,7 @@ const HeapTooltip = ({ active, payload}) => { } const NodesCountTooltip = ({ active, payload} ) => { - if (!active || payload.length === 0) return null; + if (!active || !payload || payload.length === 0) return null; return (

From ffc2f78045c40403f73d9092dc051fa1fa3c19be Mon Sep 17 00:00:00 2001 From: Shekar Siri Date: Sun, 27 Feb 2022 19:53:36 +0100 Subject: [PATCH 3/3] fix(ui) - player live check --- frontend/app/components/Session/Session.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/app/components/Session/Session.js b/frontend/app/components/Session/Session.js index 0138e7e50..210a24bff 100644 --- a/frontend/app/components/Session/Session.js +++ b/frontend/app/components/Session/Session.js @@ -16,11 +16,11 @@ const SESSIONS_ROUTE = sessionsRoute(); function Session({ sessionId, loading, - hasErrors, + hasErrors, session, fetchSession, - fetchSlackList, - hasSessionsPath + fetchSlackList, + hasSessionsPath }) { usePageTitle("OpenReplay Session Player"); useEffect(() => { @@ -51,7 +51,7 @@ function Session({ { session.isIOS ? - : (session.live && !hasSessionsPath ? : ) + : }