From b78b05791e3e35a44807e46ea83fd001c8fbf34b Mon Sep 17 00:00:00 2001
From: Shekar Siri <sshekarsiri@gmail.com>
Date: Fri, 28 Apr 2023 17:29:48 +0200
Subject: [PATCH] change(ui) - assist recordings pagination api

---
 .../Assist/RecordingsList/Recordings.tsx      | 38 +++++++----
 .../Assist/RecordingsList/RecordingsList.tsx  | 64 +++++++++----------
 frontend/app/mstore/recordingsStore.ts        | 32 +++++++---
 frontend/app/services/RecordingsService.ts    |  7 +-
 4 files changed, 86 insertions(+), 55 deletions(-)

diff --git a/frontend/app/components/Assist/RecordingsList/Recordings.tsx b/frontend/app/components/Assist/RecordingsList/Recordings.tsx
index c03b703f3..c72adf831 100644
--- a/frontend/app/components/Assist/RecordingsList/Recordings.tsx
+++ b/frontend/app/components/Assist/RecordingsList/Recordings.tsx
@@ -5,31 +5,45 @@ import RecordingsSearch from './RecordingsSearch';
 import RecordingsList from './RecordingsList';
 import { useStore } from 'App/mstore';
 import { connect } from 'react-redux';
+import SelectDateRange from 'Shared/SelectDateRange/SelectDateRange';
+import Period from 'Types/app/period';
+import { observer } from 'mobx-react-lite';
 
-function Recordings({ userId }: { userId: string }) {
+interface Props {
+  userId: string;
+  filter: any;
+}
+
+function Recordings(props: Props) {
+  const { userId } = props;
   const { recordingsStore } = useStore();
 
   const recordingsOwner = [
     { value: '0', label: 'All Recordings' },
-    { value: userId, label: 'My Recordings' },
+    { value: userId, label: 'My Recordings' }
   ];
 
+  const onDateChange = (e: any) => {
+    recordingsStore.updateTimestamps(e);
+  };
+
   return (
-    <div style={{ maxWidth: '1300px', margin: 'auto' }} className="bg-white rounded py-4 border">
-      <div className="flex items-center mb-4 justify-between px-6">
-        <div className="flex items-baseline mr-3">
-          <PageTitle title="Recordings" />
+    <div style={{ maxWidth: '1300px', margin: 'auto' }} className='bg-white rounded py-4 border'>
+      <div className='flex items-center mb-4 justify-between px-6'>
+        <div className='flex items-baseline mr-3'>
+          <PageTitle title='Recordings' />
         </div>
-        <div className="ml-auto flex items-center">
+        <div className='ml-auto flex items-center'>
+          <SelectDateRange period={recordingsStore.period} onChange={onDateChange} right={true} />
           <Select
-            name="recsOwner"
+            name='recsOwner'
             plain
             right
             options={recordingsOwner}
             onChange={({ value }) => recordingsStore.setUserId(value.value)}
             defaultValue={recordingsOwner[0].value}
           />
-          <div className="ml-4 w-1/4" style={{ minWidth: 300 }}>
+          <div className='ml-4 w-1/4' style={{ minWidth: 300 }}>
             <RecordingsSearch />
           </div>
         </div>
@@ -39,6 +53,6 @@ function Recordings({ userId }: { userId: string }) {
   );
 }
 
-export default connect((state: any) => ({ userId: state.getIn(['user', 'account', 'id']) }))(
-  Recordings
-);
+export default connect((state: any) => ({
+  userId: state.getIn(['user', 'account', 'id'])
+}))(observer(Recordings));
diff --git a/frontend/app/components/Assist/RecordingsList/RecordingsList.tsx b/frontend/app/components/Assist/RecordingsList/RecordingsList.tsx
index e186288d3..00d0d7605 100644
--- a/frontend/app/components/Assist/RecordingsList/RecordingsList.tsx
+++ b/frontend/app/components/Assist/RecordingsList/RecordingsList.tsx
@@ -1,42 +1,38 @@
 import { observer } from 'mobx-react-lite';
 import React from 'react';
-import { NoContent, Pagination, Icon, Button } from 'UI';
+import { NoContent, Pagination, Loader } from 'UI';
 import { useStore } from 'App/mstore';
-import { filterList } from 'App/utils';
-import { sliceListPerPage } from 'App/utils';
 import RecordsListItem from './RecordsListItem';
 import AnimatedSVG, { ICONS } from 'Shared/AnimatedSVG/AnimatedSVG';
 
 function RecordingsList() {
   const { recordingsStore } = useStore();
-  const [shownRecordings, setRecordings] = React.useState<any[]>([]);
+  // const [shownRecordings, setRecordings] = React.useState<any[]>([]);
   const recordings = recordingsStore.recordings;
   const recordsSearch = recordingsStore.search;
+  const page = recordingsStore.page;
+  const pageSize = recordingsStore.pageSize;
+  const total = recordingsStore.total;
 
   React.useEffect(() => {
     recordingsStore.fetchRecordings();
-  }, []);
+  }, [page, recordingsStore.period, recordsSearch, recordingsStore.userId]);
 
-  React.useEffect(() => {
-    setRecordings(filterList(recordings, recordsSearch, ['createdBy', 'name']));
-  }, [recordsSearch]);
-
-  const list = recordsSearch !== '' ? shownRecordings : recordings;
-  const length = list.length;
+  const length = recordings.length;
 
   return (
     <NoContent
       show={length === 0}
       title={
-        <div className="flex flex-col items-center justify-center">
+        <div className='flex flex-col items-center justify-center'>
           <AnimatedSVG name={ICONS.NO_RECORDINGS} size={180} />
-          <div className="text-center text-gray-600 mt-4">
+          <div className='text-center text-gray-600 mt-4'>
             {recordsSearch !== '' ? 'No matching results' : 'No recordings available yet.'}
           </div>
         </div>
       }
       subtext={
-        <div className="text-center flex justify-center items-center flex-col">
+        <div className='text-center flex justify-center items-center flex-col'>
           <span>
             Record your co-browsing sessions and share them with your team for product feedback or
             training purposes.
@@ -44,32 +40,34 @@ function RecordingsList() {
         </div>
       }
     >
-      <div className="mt-3 border-b">
-        <div className="grid grid-cols-12 py-2 font-medium px-6">
-          <div className="col-span-8">Name</div>
-          <div className="col-span-4">Recorded by</div>
-        </div>
+      <div className='mt-3 border-b'>
+        <Loader loading={recordingsStore.loading}>
+          <div className='grid grid-cols-12 py-2 font-medium px-6'>
+            <div className='col-span-8'>Name</div>
+            <div className='col-span-4'>Recorded by</div>
+          </div>
 
-        {sliceListPerPage(list, recordingsStore.page - 1, recordingsStore.pageSize).map(
-          (record: any) => (
-            <React.Fragment key={record.recordId}>
-              <RecordsListItem record={record} />
-            </React.Fragment>
-          )
-        )}
+          {recordings.map(
+            (record: any) => (
+              <React.Fragment key={record.recordId}>
+                <RecordsListItem record={record} />
+              </React.Fragment>
+            )
+          )}
+        </Loader>
       </div>
 
-      <div className="w-full flex items-center justify-between pt-4 px-6">
-        <div className="text-disabled-text">
+      <div className='w-full flex items-center justify-between pt-4 px-6'>
+        <div className='text-disabled-text'>
           Showing{' '}
-          <span className="font-semibold">{Math.min(list.length, recordingsStore.pageSize)}</span>{' '}
-          out of <span className="font-semibold">{list.length}</span> Recording
+          <span className='font-semibold'>{Math.min(length, pageSize)}</span>{' '}
+          out of <span className='font-semibold'>{total}</span> Recording
         </div>
         <Pagination
-          page={recordingsStore.page}
-          totalPages={Math.ceil(length / recordingsStore.pageSize)}
+          page={page}
+          totalPages={Math.ceil(total / pageSize)}
           onPageChange={(page) => recordingsStore.updatePage(page)}
-          limit={recordingsStore.pageSize}
+          limit={pageSize}
           debounceRequest={100}
         />
       </div>
diff --git a/frontend/app/mstore/recordingsStore.ts b/frontend/app/mstore/recordingsStore.ts
index 783c129e7..2b687df9e 100644
--- a/frontend/app/mstore/recordingsStore.ts
+++ b/frontend/app/mstore/recordingsStore.ts
@@ -1,34 +1,48 @@
 import { makeAutoObservable } from 'mobx';
 import { recordingsService } from 'App/services';
 import { IRecord } from 'App/services/RecordingsService';
+import Period, { LAST_7_DAYS } from 'Types/app/period';
 
 export default class RecordingsStore {
   recordings: IRecord[] = [];
   loading: boolean;
 
   page = 1;
-  pageSize = 15;
+  total: number = 0;
+  pageSize = 5;
   order: 'desc' | 'asc' = 'desc';
   search = '';
   // later we will add search by user id
   userId = '0';
+  startTimestamp = 0;
+  endTimestamp = 0;
+  rangeName: string = 'LAST_24_HOURS';
+  period: any = Period({ rangeName: LAST_7_DAYS });
 
   constructor() {
     makeAutoObservable(this);
   }
 
-  setRecordings(records: IRecord[]) {
+  setRecordings(records: IRecord[], total?: number) {
+    this.total = total || 0;
     this.recordings = records;
   }
 
   setUserId(userId: string) {
     this.userId = userId;
-    this.fetchRecordings();
   }
 
   updateSearch(val: string) {
     this.search = val;
+    this.page = 1;
   }
+
+  updateTimestamps(period: any): void {
+    const { start, end, rangeName } = period;
+    this.period = Period({ start, end, rangeName });
+    this.page = 1;
+  }
+
   updatePage(page: number) {
     this.page = page;
   }
@@ -38,15 +52,17 @@ export default class RecordingsStore {
       page: this.page,
       limit: this.pageSize,
       order: this.order,
-      search: this.search,
+      query: this.search,
       userId: this.userId === '0' ? undefined : this.userId,
+      startTimestamp: this.period.start,
+      endTimestamp: this.period.end
     };
 
     this.loading = true;
     try {
-      const recordings = await recordingsService.fetchRecordings(filter);
-      this.setRecordings(recordings);
-      return recordings;
+      const response: { records: [], total: number } = await recordingsService.fetchRecordings(filter);
+      this.setRecordings(response.records, response.total);
+      return response.records;
     } catch (e) {
       console.error(e);
     } finally {
@@ -54,7 +70,7 @@ export default class RecordingsStore {
     }
   }
 
-  async fetchRecordingUrl(id: number): Promise<string> {
+  async fetchRecordingUrl(id: number): Promise<string | undefined> {
     this.loading = true;
     try {
       const recording = await recordingsService.fetchRecording(id);
diff --git a/frontend/app/services/RecordingsService.ts b/frontend/app/services/RecordingsService.ts
index 6dd3845c5..c5711e136 100644
--- a/frontend/app/services/RecordingsService.ts
+++ b/frontend/app/services/RecordingsService.ts
@@ -10,7 +10,10 @@ interface FetchFilter {
   page: number;
   limit: number;
   order: 'asc' | 'desc';
-  search: string;
+  query: string;
+  startTimestamp: number;
+  endTimestamp: number;
+  userId?: string;
 }
 
 export interface IRecord {
@@ -57,7 +60,7 @@ export default class RecordingsService {
     });
   }
 
-  fetchRecordings(filters: FetchFilter): Promise<IRecord[]> {
+  fetchRecordings(filters: FetchFilter): Promise<any> {
     return this.client.post(`/assist/records`, filters).then((r) => {
         return r.json().then((j) => j.data);
     });